install: Enhanced NASM Finder Script#57461
Closed
sokkaofthewatertribe wants to merge 2 commits intonodejs:mainfrom
sokkaofthewatertribe:main
Closed
install: Enhanced NASM Finder Script#57461sokkaofthewatertribe wants to merge 2 commits intonodejs:mainfrom sokkaofthewatertribe:main
sokkaofthewatertribe wants to merge 2 commits intonodejs:mainfrom
sokkaofthewatertribe:main
Conversation
nodejs-github-bot
added
install
sokkaofthewatertribe
changed the title
jasnell
approved these changes
Mar 14, 2025
Member
|
cc @nodejs/platform-windows |
marco-ippolito
approved these changes
Mar 17, 2025
StefanStojanovic
approved these changes
Mar 17, 2025
Contributor
StefanStojanovic
left a comment
StefanStojanovic
left a comment
There was a problem hiding this comment.
LGTM.
The commit message checker is complaining about using install: ..., I'd suggest changing it to something like build,tools: ..., or anything else that makes sense and that would make the check pass. In addition, since you'll be changing your commits, you can squash them together as well.
lpinca
approved these changes
Mar 20, 2025
lpinca
added
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enhances the NASM finder script to search for NASM installations in additional common locations, improving the likelihood of finding an existing NASM installation on Windows systems.